]> asedeno.scripts.mit.edu Git - PuTTY.git/commit
Charles Wilcox reported a signature validation bug with 2500-bit RSA
authorSimon Tatham <anakin@pobox.com>
Sat, 7 Feb 2004 10:02:20 +0000 (10:02 +0000)
committerSimon Tatham <anakin@pobox.com>
Sat, 7 Feb 2004 10:02:20 +0000 (10:02 +0000)
commit72e538e3b27e3a8af248fdff96e71b850a6e20e7
tree5db1f2d2c82b612f148d3e52dd9906c42cae5ecb
parentb33dc07ff8fca620da64172bfa2b426bd365f0b7
Charles Wilcox reported a signature validation bug with 2500-bit RSA
keys. This _appears_ to be due to me computing the byte count of the
key by dividing the bit count by 8 and rounding _down_ rather than
up. Therefore, I can't see how this code could ever have worked on
any SSH2 RSA key whose length was not a multiple of 8 bits; and
therefore I'm staggered that we haven't noticed it before! OpenSSH's
keygen appears to be scrupulous about ensuring the returned key
length is exactly what you asked for rather than one bit less, but
even so I'm astonished that _all_ keygen implementations for servers
we've ever interoperated with have avoided tripping this bug...

[originally from svn r3815]
sshrsa.c