]> asedeno.scripts.mit.edu Git - linux.git/commit
net: devlink: add warning for ndo_get_phys_port_name set when not needed
authorJiri Pirko <jiri@mellanox.com>
Thu, 28 Mar 2019 12:56:46 +0000 (13:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Mar 2019 19:55:31 +0000 (12:55 -0700)
commit746364f298d48cc89067e6d0c9bc1a4da1efb52a
tree3a4d5031f135209c4db0a6027e7b983e45caca40
parentf1fa719cfd552dccdfe80e6f81be8d15503dfcce
net: devlink: add warning for ndo_get_phys_port_name set when not needed

Currently if the driver registers devlink port instance, it should set
the devlink port attributes as well. Then the devlink core is able to
obtain physical port name itself, no need for driver to implement
the ndo. Once all drivers will implement devlink port registration,
this ndo should be removed. This warning guides new
drivers to do things as they should be done.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c