]> asedeno.scripts.mit.edu Git - linux.git/commit
orangefs: reverse sense of is-inode-stale test in d_revalidate
authorMartin Brandenburg <martin@omnibond.com>
Tue, 6 Feb 2018 14:01:26 +0000 (14:01 +0000)
committerMike Marshall <hubcap@omnibond.com>
Tue, 6 Feb 2018 21:38:13 +0000 (16:38 -0500)
commit74e938c22705c7b80d4422e84eea927fc78e60a8
tree02704ab50e56c7d2bd520f6882861ac294dedd3c
parent480e5ae9b860c8a1c74ab9414f9bd78a43ad356f
orangefs: reverse sense of is-inode-stale test in d_revalidate

If a dentry is deleted, then a dentry is recreated with the same handle
but a different type (i.e. it was a file and now it's a symlink), then
its a different inode.  The check was backwards, so d_revalidate would
not have noticed.

Due to the design of the OrangeFS server, this is rather unlikely.

It's also possible for the dentry to be deleted and recreated with the
same type.  This would be undetectable.  It's a bit of a ship of
Theseus.

Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
fs/orangefs/dcache.c