]> asedeno.scripts.mit.edu Git - linux.git/commit
media: dib0700: fix link error for dibx000_i2c_set_speed
authorArnd Bergmann <arnd@arndb.de>
Fri, 28 Jun 2019 12:14:53 +0000 (08:14 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 22 Jul 2019 19:28:37 +0000 (15:28 -0400)
commit765bb8610d305ee488b35d07e2a04ae52fb2df9c
tree97766f35730854cbafd535cf21800ef32478cd9c
parent0c4df39e504bf925ab666132ac3c98d6cbbe380b
media: dib0700: fix link error for dibx000_i2c_set_speed

When CONFIG_DVB_DIB9000 is disabled, we can still compile code that
now fails to link against dibx000_i2c_set_speed:

drivers/media/usb/dvb-usb/dib0700_devices.o: In function `dib01x0_pmu_update.constprop.7':
dib0700_devices.c:(.text.unlikely+0x1c9c): undefined reference to `dibx000_i2c_set_speed'

The call sites are both through dib01x0_pmu_update(), which gets passed
an 'i2c' pointer from dib9000_get_i2c_master(), which has returned
NULL. Checking this pointer seems to be a good idea anyway, and it avoids
the link failure in most cases.

Sean Young found another case that is not fixed by that, where certain
gcc versions leave an unused function in place that causes the link error,
but adding an explict IS_ENABLED() check also solves this.

Fixes: b7f54910ce01 ("V4L/DVB (4647): Added module for DiB0700 based devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/dvb-usb/dib0700_devices.c