]> asedeno.scripts.mit.edu Git - linux.git/commit
nvme: cleanup double shift issue
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Jun 2018 08:27:41 +0000 (11:27 +0300)
committerJens Axboe <axboe@kernel.dk>
Fri, 8 Jun 2018 18:51:11 +0000 (12:51 -0600)
commit77016199f11eacd7b23e2faeb4d0f36166e3530b
treef057546cbab3803e4469af86bebfb6aa0fbf4ca2
parent69f4eb9ff79556c1a3daf5af5573594c196f30cc
nvme: cleanup double shift issue

The problem here is that set_bit() and test_bit() take a bit number so
we should be passing 0 but instead we're passing (1 << 0) which leads to
a double shift.  It doesn't cause a runtime bug in the current code
because it's done consistently and we only set that one bit.

I decided to just re-use NVME_AER_NOTICE_NS_CHANGED instead of
introducing a new define for this.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/core.c
drivers/nvme/host/nvme.h