]> asedeno.scripts.mit.edu Git - linux.git/commit
qed: Avoid implicit enum conversion in qed_iwarp_parse_rx_pkt
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 24 Sep 2018 21:42:12 +0000 (14:42 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Sep 2018 03:23:16 +0000 (20:23 -0700)
commit77f2d753819b7d50c16abfb778caf1fe075faed0
treeb23396c63cd02f3e3d5a4ea095d002e0ca79e448
parent1c492a9d55ba99079210ed901dd8a5423f980487
qed: Avoid implicit enum conversion in qed_iwarp_parse_rx_pkt

Clang warns when one enumerated type is implicitly converted to another.

drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1713:25: warning: implicit
conversion from enumeration type 'enum tcp_ip_version' to different
enumeration type 'enum qed_tcp_ip_version' [-Wenum-conversion]
                cm_info->ip_version = TCP_IPV4;
                                    ~ ^~~~~~~~
drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1733:25: warning: implicit
conversion from enumeration type 'enum tcp_ip_version' to different
enumeration type 'enum qed_tcp_ip_version' [-Wenum-conversion]
                cm_info->ip_version = TCP_IPV6;
                                    ~ ^~~~~~~~
2 warnings generated.

Use the appropriate values from the expected type, qed_tcp_ip_version:

TCP_IPV4 = QED_TCP_IPV4 = 0
TCP_IPV6 = QED_TCP_IPV6 = 1

Link: https://github.com/ClangBuiltLinux/linux/issues/125
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_iwarp.c