]> asedeno.scripts.mit.edu Git - linux.git/commit
IB/hfi1: Fix logical condition in msix_request_irq
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 16 Jan 2020 22:26:58 +0000 (15:26 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Sat, 25 Jan 2020 19:33:53 +0000 (15:33 -0400)
commit79ba4f9310673a8870fda5a062a558923fa65c93
tree6fb568a025f62b4df444cea49362839402671eef
parent13e0af1801f2e74639b4eadb69ed1fad2cf802f7
IB/hfi1: Fix logical condition in msix_request_irq

Clang warns:

drivers/infiniband/hw/hfi1/msix.c:136:22: warning: overlapping
comparisons always evaluate to false [-Wtautological-overlap-compare]
        if (type < IRQ_SDMA && type >= IRQ_OTHER)
            ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
1 warning generated.

It is impossible for something to be less than 0 (IRQ_SDMA) and greater
than or equal to 3 (IRQ_OTHER) at the same time. A logical OR should
have been used to keep the same logic as before.

Link: https://lore.kernel.org/r/20200116222658.5285-1-natechancellor@gmail.com
Link: https://github.com/ClangBuiltLinux/linux/issues/841
Fixes: 13d2a8384bd9 ("IB/hfi1: Decouple IRQ name from type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/msix.c