]> asedeno.scripts.mit.edu Git - linux.git/commit
Drivers: hv: vmbus: Fix crash handler reset of Hyper-V synic
authorMichael Kelley <mikelley@microsoft.com>
Thu, 14 Nov 2019 06:32:01 +0000 (06:32 +0000)
committerSasha Levin <sashal@kernel.org>
Fri, 22 Nov 2019 01:10:46 +0000 (20:10 -0500)
commit7a1323b5dfe44a9013a2cc56ef2973034a00bf88
tree2878fe886a0cbb5f3fdb2840a11d5acdc73f3523
parent8aea7f82153d6f292add3eb4bd7ba8edcae5c7f7
Drivers: hv: vmbus: Fix crash handler reset of Hyper-V synic

The crash handler calls hv_synic_cleanup() to shutdown the
Hyper-V synthetic interrupt controller.  But if the CPU
that calls hv_synic_cleanup() has a VMbus channel interrupt
assigned to it (which is likely the case in smaller VM sizes),
hv_synic_cleanup() returns an error and the synthetic
interrupt controller isn't shutdown.  While the lack of
being shutdown hasn't caused a known problem, it still
should be fixed for highest reliability.

So directly call hv_synic_disable_regs() instead of
hv_synic_cleanup(), which ensures that the synic is always
shutdown.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hv/vmbus_drv.c