]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 9 Apr 2018 10:47:37 +0000 (18:47 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 16 Apr 2018 10:53:40 +0000 (11:53 +0100)
commit7a3a63238fc1d93aa998671de56af2202d776010
tree72e8cbf1e11754c009eb169bc8876ff0dadab95d
parent270e1ad6d1f76dfebea19a277a65cefd185f85b0
ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe

snd_byt_rt5640_mc_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
snd_byt_rt5640_mc_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5640.c