]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove
authorAnton Vasilyev <vasilyev@ispras.ru>
Tue, 15 Aug 2017 12:19:54 +0000 (15:19 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 15 Aug 2017 17:48:55 +0000 (18:48 +0100)
commit7b814a7d4e83b0917efef9dd11a8c095371f987c
tree8116e573b8b3967c468bf20a08fdeeba684ae392
parentd92dd70e9a47cce7d51bda584e7910efd0c4ba20
ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove

If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate
sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove()
performs pri_dai->sec_dai dereference in any case.

The patch removes useless reinitialization of sec_dai at
samsung_i2s_remove(), because resources are under devm control.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/samsung/i2s.c