]> asedeno.scripts.mit.edu Git - linux.git/commit
exec: Set file unwritable before LSM check
authorKees Cook <keescook@chromium.org>
Fri, 9 Mar 2018 19:30:20 +0000 (11:30 -0800)
committerJames Morris <james.morris@microsoft.com>
Mon, 19 Mar 2018 04:49:32 +0000 (15:49 +1100)
commit7bd698b3c04e61ee9e03d4c2a55003f75df14dca
treed15e529bab47370611aa871465662775f9798027
parent6b4f3d01052a479c7ebbe99d52a663558dc1be2a
exec: Set file unwritable before LSM check

The LSM check should happen after the file has been confirmed to be
unchanging. Without this, we could have a race between the Time of Check
(the call to security_kernel_read_file() which could read the file and
make access policy decisions) and the Time of Use (starting with
kernel_read_file()'s reading of the file contents). In theory, file
contents could change between the two.

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: James Morris <james.morris@microsoft.com>
fs/exec.c