]> asedeno.scripts.mit.edu Git - linux.git/commit
dm cache: fix a crash due to incorrect work item cancelling
authorMikulas Patocka <mpatocka@redhat.com>
Wed, 19 Feb 2020 15:25:45 +0000 (10:25 -0500)
committerMike Snitzer <snitzer@redhat.com>
Thu, 27 Feb 2020 17:00:52 +0000 (12:00 -0500)
commit7cdf6a0aae1cccf5167f3f04ecddcf648b78e289
tree115172a66547e3074c3c57ada5dd5ac130a98f4d
parent7fc2e47f40dd77ab1fcbda6db89614a0173d89c7
dm cache: fix a crash due to incorrect work item cancelling

The crash can be reproduced by running the lvm2 testsuite test
lvconvert-thin-external-cache.sh for several minutes, e.g.:
  while :; do make check T=shell/lvconvert-thin-external-cache.sh; done

The crash happens in this call chain:
do_waker -> policy_tick -> smq_tick -> end_hotspot_period -> clear_bitset
-> memset -> __memset -- which accesses an invalid pointer in the vmalloc
area.

The work entry on the workqueue is executed even after the bitmap was
freed. The problem is that cancel_delayed_work doesn't wait for the
running work item to finish, so the work item can continue running and
re-submitting itself even after cache_postsuspend. In order to make sure
that the work item won't be running, we must use cancel_delayed_work_sync.

Also, change flush_workqueue to drain_workqueue, so that if some work item
submits itself or another work item, we are properly waiting for both of
them.

Fixes: c6b4fcbad044 ("dm: add cache target")
Cc: stable@vger.kernel.org # v3.9
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-cache-target.c