]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915/gem: Take timeline->mutex to walk list-of-requests
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 29 Nov 2019 15:18:45 +0000 (15:18 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 29 Nov 2019 20:09:14 +0000 (20:09 +0000)
commit7ce596a8036cf3a4cb9ffa0c4edd8a76a7a43cc3
treef05d17f8d40044d452ffc8c615d13b2dc573877a
parent8d9875b47a5dae0690b04bbb9de68b0a0f1a2cce
drm/i915/gem: Take timeline->mutex to walk list-of-requests

Though the context is closed and so no more requests can be added to the
timeline, retirement can still be removing requests. It can even be
removing the very request we are inspecting and so cause us to wander
into dead links.

Serialise with the retirement by taking the timeline->mutex used for
guarding the timeline->requests list.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112404
Fixes: 4a3174152147 ("drm/i915/gem: Refine occupancy test in kill_context()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191129151845.1092933-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gem/i915_gem_context.c