]> asedeno.scripts.mit.edu Git - linux.git/commit
backlight: lm3639: Unconditionally call led_classdev_unregister
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 21 Sep 2018 20:21:31 +0000 (13:21 -0700)
committerLee Jones <lee.jones@linaro.org>
Tue, 9 Oct 2018 09:58:59 +0000 (02:58 -0700)
commit7cea645ae9c5a54aa7904fddb2cdf250acd63a6c
tree92549fd84a152e629d5c605190039a58288aeac5
parente6bcca0890b96a3c2c5e72169de72ba4d2b01b78
backlight: lm3639: Unconditionally call led_classdev_unregister

Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/video/backlight/lm3639_bl.c:403:14: warning: address of
'pchip->cdev_torch' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (&pchip->cdev_torch)
        ~~   ~~~~~~~^~~~~~~~~~
drivers/video/backlight/lm3639_bl.c:405:14: warning: address of
'pchip->cdev_flash' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (&pchip->cdev_flash)
        ~~   ~~~~~~~^~~~~~~~~~
2 warnings generated.

These statements have been present since 2012, introduced by
commit 0f59858d5119 ("backlight: add new lm3639 backlight
driver"). Given that they have been called unconditionally since
then presumably without any issues, removing the always true if
statements to fix the warnings without any real world changes.

Link: https://github.com/ClangBuiltLinux/linux/issues/119
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/video/backlight/lm3639_bl.c