]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/modes: Skip invalid cmdline mode
authorDmitry Osipenko <digetx@gmail.com>
Tue, 9 Jul 2019 14:51:51 +0000 (17:51 +0300)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Wed, 10 Jul 2019 10:11:18 +0000 (12:11 +0200)
commit7f3bbc0b817b51206948b743331c7441bf918c7f
treeb0ea63b72fd0b2640ec11141cafb364a8dd9d798
parent990dee3aa45690217e8d83e7704cf07b2f3d9821
drm/modes: Skip invalid cmdline mode

The named mode could be invalid and then cmdline parser misses to validate
mode's dimensions, happily adding 0x0 mode as a valid mode. One case where
this happens is NVIDIA Tegra devices that are using downstream bootloader
which adds "video=tegrafb" to the kernel's cmdline and thus upstream Tegra
DRM driver fails to probe because of the invalid mode.

Fixes: 3aeeb13d8996 ("drm/modes: Support modes names on the command line")
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190709145151.23086-1-digetx@gmail.com
drivers/gpu/drm/drm_client_modeset.c
drivers/gpu/drm/drm_modes.c