]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/sun4i: tcon: fix check of tcon->panel null pointer
authorGiulio Benetti <giulio.benetti@micronovasrl.com>
Fri, 5 Oct 2018 21:59:50 +0000 (23:59 +0200)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Tue, 6 Nov 2018 15:55:24 +0000 (16:55 +0100)
commit7f4cedd882f7cae83177066c2b239ef457ce4a42
tree016de1a53bbe2bc25c70ce834533089fac2db49f
parent651022382c7f8da46cb4872a545ee1da6d097d2a
drm/sun4i: tcon: fix check of tcon->panel null pointer

Since tcon->panel is a pointer returned by of_drm_find_panel() need to
check if it is not NULL, hence a valid pointer.
IS_ERR() instead checks return error values, not NULL pointers.

Substitute "if (!IS_ERR(tcon->panel))" with "if (tcon->panel)".

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181005215951.99003-1-giulio.benetti@micronovasrl.com
drivers/gpu/drm/sun4i/sun4i_lvds.c
drivers/gpu/drm/sun4i/sun4i_rgb.c
drivers/gpu/drm/sun4i/sun4i_tcon.c