]> asedeno.scripts.mit.edu Git - linux.git/commit
platform/x86: fujitsu-laptop: Simplify error paths
authorMichał Kępień <kernel@kempniu.pl>
Sun, 11 Feb 2018 21:07:23 +0000 (22:07 +0100)
committerDarren Hart (VMware) <dvhart@infradead.org>
Sat, 24 Feb 2018 21:37:36 +0000 (13:37 -0800)
commit7f83d410440e63b173a91c65bb2515fa38501092
tree6c0c38fd7cd796d4d8297652e6d113f91513bc08
parenta7a1ccbee3b61bdb044d3bbee958a3082cf8f9f9
platform/x86: fujitsu-laptop: Simplify error paths

Replace the last few lines of acpi_fujitsu_bl_add() with a simple return
in order to improve code readability without changing the logic.

As acpi_fujitsu_laptop_add() uses a managed memory allocation for
device-specific data, it is fine to just return immediately upon kfifo
allocation failure.  Do that instead of jumping to the end of the
function to improve code readability.  Running out of memory while
allocating the kfifo does not seem probable enough to warrant logging an
error message, so do not do it.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/fujitsu-laptop.c