]> asedeno.scripts.mit.edu Git - linux.git/commit
x86/mm/pti: Handle unaligned address gracefully in pti_clone_pagetable()
authorSong Liu <songliubraving@fb.com>
Wed, 28 Aug 2019 21:54:55 +0000 (23:54 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 29 Aug 2019 18:52:52 +0000 (20:52 +0200)
commit825d0b73cd7526b0bb186798583fae810091cbac
tree4bf50b03cc2e6598ba585f19bc8ce5cdd1d36945
parenta55aa89aab90fae7c815b0551b07be37db359d76
x86/mm/pti: Handle unaligned address gracefully in pti_clone_pagetable()

pti_clone_pmds() assumes that the supplied address is either:

 - properly PUD/PMD aligned
or
 - the address is actually mapped which means that independently
   of the mapping level (PUD/PMD/PTE) the next higher mapping
   exists.

If that's not the case the unaligned address can be incremented by PUD or
PMD size incorrectly. All callers supply mapped and/or aligned addresses,
but for the sake of robustness it's better to handle that case properly and
to emit a warning.

[ tglx: Rewrote changelog and added WARN_ON_ONCE() ]

Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1908282352470.1938@nanos.tec.linutronix.de
arch/x86/mm/pti.c