]> asedeno.scripts.mit.edu Git - linux.git/commit
mfd / platform: cros_ec: Reorganize platform and mfd includes
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Mon, 2 Sep 2019 09:53:05 +0000 (11:53 +0200)
committerLee Jones <lee.jones@linaro.org>
Mon, 2 Sep 2019 10:33:42 +0000 (11:33 +0100)
commit840d9f131f65b021e0a73f3371f3194897dba6ad
tree8da2f672f55cb9f894e49b96df5885483a240b71
parent2fa2b980e3fe187a0b916bfe6bd5822889b44d5e
mfd / platform: cros_ec: Reorganize platform and mfd includes

There is a bit of mess between cros-ec mfd includes and platform
includes. For example, we have a linux/mfd/cros_ec.h include that
exports the interface implemented in platform/chrome/cros_ec_proto.c. Or
we have a linux/mfd/cros_ec_commands.h file that is non related to the
multifunction device (in the sense that is not exporting any function of
the mfd device). This causes crossed includes between mfd and
platform/chrome subsystems and makes the code difficult to read, apart
from creating 'curious' situations where a platform/chrome driver includes
a linux/mfd/cros_ec.h file just to get the exported functions that are
implemented in another platform/chrome driver.

In order to have a better separation on what the cros-ec multifunction
driver does and what the cros-ec core provides move and rework the
affected includes doing:

 - Move cros_ec_commands.h to include/linux/platform_data/cros_ec_commands.h
 - Get rid of the parts that are implemented in the platform/chrome/cros_ec_proto.c
   driver from include/linux/mfd/cros_ec.h to a new file
   include/linux/platform_data/cros_ec_proto.h
 - Update all the drivers with the new includes, so
   - Drivers that only need to know about the protocol include
     - linux/platform_data/cros_ec_proto.h
     - linux/platform_data/cros_ec_commands.h
   - Drivers that need to know about the cros-ec mfd device also include
     - linux/mfd/cros_ec.h

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Series changes: 3
- Fix dereferencing pointer to incomplete type 'struct cros_ec_dev' (lkp)
Signed-off-by: Lee Jones <lee.jones@linaro.org>
37 files changed:
drivers/extcon/extcon-usbc-cros-ec.c
drivers/hid/hid-google-hammer.c
drivers/i2c/busses/i2c-cros-ec-tunnel.c
drivers/iio/accel/cros_ec_accel_legacy.c
drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c
drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
drivers/iio/light/cros_ec_light_prox.c
drivers/iio/pressure/cros_ec_baro.c
drivers/input/keyboard/cros_ec_keyb.c
drivers/media/platform/cros-ec-cec/cros-ec-cec.c
drivers/mfd/cros_ec_dev.c
drivers/platform/chrome/cros_ec.c
drivers/platform/chrome/cros_ec_chardev.c
drivers/platform/chrome/cros_ec_debugfs.c
drivers/platform/chrome/cros_ec_i2c.c
drivers/platform/chrome/cros_ec_ishtp.c
drivers/platform/chrome/cros_ec_lightbar.c
drivers/platform/chrome/cros_ec_lpc.c
drivers/platform/chrome/cros_ec_proto.c
drivers/platform/chrome/cros_ec_rpmsg.c
drivers/platform/chrome/cros_ec_spi.c
drivers/platform/chrome/cros_ec_sysfs.c
drivers/platform/chrome/cros_ec_trace.c
drivers/platform/chrome/cros_ec_trace.h
drivers/platform/chrome/cros_ec_vbc.c
drivers/platform/chrome/cros_usbpd_logger.c
drivers/power/supply/cros_usbpd-charger.c
drivers/pwm/pwm-cros-ec.c
drivers/rtc/rtc-cros-ec.c
include/Kbuild
include/linux/iio/common/cros_ec_sensors_core.h
include/linux/mfd/cros_ec.h
include/linux/platform_data/cros_ec_chardev.h
include/linux/platform_data/cros_ec_commands.h [moved from include/linux/mfd/cros_ec_commands.h with 100% similarity]
include/linux/platform_data/cros_ec_proto.h [new file with mode: 0644]
sound/soc/codecs/cros_ec_codec.c