]> asedeno.scripts.mit.edu Git - linux.git/commit
KVM: arm/arm64: Skip updating PMD entry if no change
authorPunit Agrawal <punit.agrawal@arm.com>
Mon, 13 Aug 2018 10:43:50 +0000 (11:43 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Mon, 13 Aug 2018 14:31:35 +0000 (15:31 +0100)
commit86658b819cd0a9aa584cd84453ed268a6f013770
treed49db9889156ee21920685884b8b37f373668cbd
parent062a585ec21ea478be4826be7ddddb5b3ac49789
KVM: arm/arm64: Skip updating PMD entry if no change

Contention on updating a PMD entry by a large number of vcpus can lead
to duplicate work when handling stage 2 page faults. As the page table
update follows the break-before-make requirement of the architecture,
it can lead to repeated refaults due to clearing the entry and
flushing the tlbs.

This problem is more likely when -

* there are large number of vcpus
* the mapping is large block mapping

such as when using PMD hugepages (512MB) with 64k pages.

Fix this by skipping the page table update if there is no change in
the entry being updated.

Cc: stable@vger.kernel.org
Fixes: ad361f093c1e ("KVM: ARM: Support hugetlbfs backed huge pages")
Reviewed-by: Suzuki Poulose <suzuki.poulose@arm.com>
Acked-by: Christoffer Dall <christoffer.dall@arm.com>
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
virt/kvm/arm/mmu.c