]> asedeno.scripts.mit.edu Git - linux.git/commit
bcache: don't attach backing with duplicate UUID
authorMichael Lyle <mlyle@lyle.org>
Mon, 5 Mar 2018 21:41:55 +0000 (13:41 -0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 5 Mar 2018 21:43:07 +0000 (14:43 -0700)
commit86755b7a96faed57f910f9e6b8061e019ac1ec08
tree9d26c1271fbad3739fe8b78fe698182cc4be1353
parentcc40daf91bdddbba72a4a8cd0860640e06668309
bcache: don't attach backing with duplicate UUID

This can happen e.g. during disk cloning.

This is an incomplete fix: it does not catch duplicate UUIDs earlier
when things are still unattached.  It does not unregister the device.
Further changes to cope better with this are planned but conflict with
Coly's ongoing improvements to handling device errors.  In the meantime,
one can manually stop the device after this has happened.

Attempts to attach a duplicate device result in:

[  136.372404] loop: module loaded
[  136.424461] bcache: register_bdev() registered backing device loop0
[  136.424464] bcache: bch_cached_dev_attach() Tried to attach loop0 but duplicate UUID already attached

My test procedure is:

  dd if=/dev/sdb1 of=imgfile bs=1024 count=262144
  losetup -f imgfile

Signed-off-by: Michael Lyle <mlyle@lyle.org>
Reviewed-by: Tang Junhui <tang.junhui@zte.com.cn>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c