]> asedeno.scripts.mit.edu Git - linux.git/commit
iwlwifi: mvm: fix endianity issues with Smart Fifo commands
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 31 Jul 2014 11:32:37 +0000 (14:32 +0300)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Mon, 8 Sep 2014 06:17:09 +0000 (09:17 +0300)
commit86974bff066dd8b98be46d7c7d3aba89034f0833
tree9ae70d47f736f066c72e43ccf00d137a6ee71887
parent7c8b3bc688bdcfd7789efbd17da4d85b104ad351
iwlwifi: mvm: fix endianity issues with Smart Fifo commands

This code was broken on big endian systems. Sparse didn't
catch the bug since the firmware command was not tagged as
little endian.
Fix the bug for big endian systems and tag the field in the
firmware command to prevent such issues in the future.

Cc: stable@vger.kernel.org [3.14+]
Fixes: 1f3b0ff8ec ("iwlwifi: mvm: Add Smart FIFO support")
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/mvm/fw-api.h
drivers/net/wireless/iwlwifi/mvm/sf.c