]> asedeno.scripts.mit.edu Git - linux.git/commit
media: uvc: to the right check at uvc_ioctl_enum_framesizes()
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 23 Mar 2018 12:23:23 +0000 (08:23 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 23 Mar 2018 12:37:27 +0000 (08:37 -0400)
commit86b2989361df6fd9bb3f46518b5326775c76358d
treee9c09f4288f59bf15edaea63aad46252d306c4f6
parent98c1ce0ccff1617cba45e8ead236768a50545e7f
media: uvc: to the right check at uvc_ioctl_enum_framesizes()

While the logic there is correct, it tricks both humans and
machines, a the check if "i" var is not zero is actually to
validate if the "frames" var was initialized when the loop
ran for the first time.

That produces the following warning:
drivers/media/usb/uvc/uvc_v4l2.c:1192 uvc_ioctl_enum_framesizes() error: potentially dereferencing uninitialized 'frame'.

Change the logic to do the right test instead.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/uvc/uvc_v4l2.c