]> asedeno.scripts.mit.edu Git - linux.git/commit
clocksource/drivers/fttmr010: Fix invalid interrupt register access
authorTao Ren <taoren@fb.com>
Wed, 3 Oct 2018 21:53:50 +0000 (14:53 -0700)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 18 Dec 2018 21:22:23 +0000 (22:22 +0100)
commit86fe57fc47b17b3528fa5497fc57e158d846c4ea
tree0cb9600b95fa0300f5834bd280d9bcbd6e677604
parent5eb73c831171115d3b4347e1e7124a5a35d8086c
clocksource/drivers/fttmr010: Fix invalid interrupt register access

TIMER_INTR_MASK register (Base Address of Timer + 0x38) is not designed
for masking interrupts on ast2500 chips, and it's not even listed in
ast2400 datasheet, so it's not safe to access TIMER_INTR_MASK on aspeed
chips.

Similarly, TIMER_INTR_STATE register (Base Address of Timer + 0x34) is
not interrupt status register on ast2400 and ast2500 chips. Although
there is no side effect to reset the register in fttmr010_common_init(),
it's just misleading to do so.

Besides, "count_down" is renamed to "is_aspeed" in "fttmr010" structure,
and more comments are added so the code is more readble.

Signed-off-by: Tao Ren <taoren@fb.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/timer-fttmr010.c