]> asedeno.scripts.mit.edu Git - linux.git/commit
gpio/mmc/of: Respect polarity in the device tree
authorLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Dec 2018 21:36:25 +0000 (22:36 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Dec 2018 22:31:07 +0000 (23:31 +0100)
commit89a5e15bcba87df5120d4656e0ff33d4f7cd6152
treefa49fb40f088e9cef1b606228a6d3ac91dd8e71c
parent12d6dd06989171ba9486790116832a65c5316fb1
gpio/mmc/of: Respect polarity in the device tree

The device tree bindings for the MMC card detect and
write protect lines specify that these should be active
low unless "cd-inverted" or "wp-inverted" has been
specified.

However that is not how the kernel code has worked. It
has always respected the flags passed to the phandle in
the device tree, but respected the "cd-inverted" and
"wp-inverted" flags such that if those are set, the
polarity will be the inverse of that specified in the
device tree.

Switch to behaving like the old code did and fix the
regression.

Fixes: 81c85ec15a19 ("gpio: OF: Parse MMC-specific CD and WP properties")
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-of.c