]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/nouveau/pmu/gm20b,gp10b: Fix Falcon bootstrapping
authorThierry Reding <treding@nvidia.com>
Wed, 15 Jan 2020 14:06:13 +0000 (15:06 +0100)
committerBen Skeggs <bskeggs@redhat.com>
Wed, 22 Jan 2020 22:56:51 +0000 (08:56 +1000)
commit89b34254bb61d0ad5c701413572cf3d993c9bff8
tree3c9759ba958adc9c85befd79f106105e1a7c1f08
parentafa3b96b058d87c2c44d1c83dadb2ba6998d03ce
drm/nouveau/pmu/gm20b,gp10b: Fix Falcon bootstrapping

The low-level Falcon bootstrapping callbacks are expected to return 0 on
success or a negative error code on failure. However, the implementation
on Tegra returns the ID or mask of the Falcons that were bootstrapped on
success, thus breaking the calling code, which treats this as failure.

Fix this by making sure we only return 0 or a negative error code, just
like the code for discrete GPUs does.

Fixes: 86ce2a71539c ("drm/nouveau/flcn/cmdq: move command generation to subdevs")
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gm20b.c
drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c