]> asedeno.scripts.mit.edu Git - linux.git/commit
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 7 Mar 2019 22:56:51 +0000 (15:56 -0700)
committerMatthias Brugger <matthias.bgg@gmail.com>
Fri, 12 Apr 2019 19:57:49 +0000 (21:57 +0200)
commit89e28da82836530f1ac7a3a32fecc31f22d79b3e
tree1d3e970a9343d6e9b1fb230ddefac02b39459677
parent45a0686b91205ad4a83cfe8548e95a04f69565e0
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher

When building with -Wsometimes-uninitialized, Clang warns:

drivers/soc/mediatek/mtk-pmic-wrap.c:1358:6: error: variable 'rdata' is
used uninitialized whenever '||' condition is true
[-Werror,-Wsometimes-uninitialized]

If pwrap_write returns non-zero, pwrap_read will not be called to
initialize rdata, meaning that we will use some random uninitialized
stack value in our print statement. Zero initialize rdata in case this
happens.

Link: https://github.com/ClangBuiltLinux/linux/issues/401
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
drivers/soc/mediatek/mtk-pmic-wrap.c