]> asedeno.scripts.mit.edu Git - linux.git/commit
fuse: fix congested state leak on aborted connections
authorTejun Heo <tj@kernel.org>
Fri, 2 Feb 2018 17:54:14 +0000 (09:54 -0800)
committerMiklos Szeredi <mszeredi@redhat.com>
Thu, 31 May 2018 10:26:10 +0000 (12:26 +0200)
commit8a301eb16d99983a4961f884690ec97b92e7dcfe
treed012a1a21be4c9c5b5248e5dcda88d4ba50125cc
parent4ad769f3c346ec3d458e255548dec26ca5284cf6
fuse: fix congested state leak on aborted connections

If a connection gets aborted while congested, FUSE can leave
nr_wb_congested[] stuck until reboot causing wait_iff_congested() to
wait spuriously which can lead to severe performance degradation.

The leak is caused by gating congestion state clearing with
fc->connected test in request_end().  This was added way back in 2009
by 26c3679101db ("fuse: destroy bdi on umount").  While the commit
description doesn't explain why the test was added, it most likely was
to avoid dereferencing bdi after it got destroyed.

Since then, bdi lifetime rules have changed many times and now we're
always guaranteed to have access to the bdi while the superblock is
alive (fc->sb).

Drop fc->connected conditional to avoid leaking congestion states.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Joshua Miller <joshmiller@fb.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: stable@vger.kernel.org # v2.6.29+
Acked-by: Jan Kara <jack@suse.cz>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/dev.c