]> asedeno.scripts.mit.edu Git - linux.git/commit
net/mlx4: Use cpumask_available for eq->affinity_mask
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 21 Sep 2018 09:44:12 +0000 (02:44 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Sep 2018 02:20:22 +0000 (19:20 -0700)
commit8ac1ee6f4d62e781e3b3fd8b9c42b70371427669
treee05847c13593dbc8e1edad3e19d2890dd7e684f3
parent83fe9a966111b51a34f10c35e568e45bff34de48
net/mlx4: Use cpumask_available for eq->affinity_mask

Clang warns that the address of a pointer will always evaluated as true
in a boolean context:

drivers/net/ethernet/mellanox/mlx4/eq.c:243:11: warning: address of
array 'eq->affinity_mask' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (!eq->affinity_mask || cpumask_empty(eq->affinity_mask))
            ~~~~~^~~~~~~~~~~~~
1 warning generated.

Use cpumask_available, introduced in commit f7e30f01a9e2 ("cpumask: Add
helper cpumask_available()"), which does the proper checking and avoids
this warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/86
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/eq.c