]> asedeno.scripts.mit.edu Git - linux.git/commit
arm64: dts: meson: Fix IRQ trigger type for macirq
authorCarlo Caione <ccaione@baylibre.com>
Fri, 7 Dec 2018 10:52:30 +0000 (10:52 +0000)
committerKevin Hilman <khilman@baylibre.com>
Fri, 7 Dec 2018 21:48:58 +0000 (13:48 -0800)
commit8b3e6f8999f8d704fccce225b9455b3fa639d1c9
treee32e27092e2ae7f58fa923910fd85c29cf34922f
parentcbddb02e37b8bad058e1c552d4db87aa4d7c9582
arm64: dts: meson: Fix IRQ trigger type for macirq

A long running stress test on a custom board shipping an AXG SoCs and a
Realtek RTL8211F PHY revealed that after a few hours the connection
speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
the 'macirq' (eth0) IRQ would stop being triggered at all and as
consequence the GMAC IRQs never ACKed.

After a painful investigation the problem seemed to be due to a wrong
defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
EDGE_RISING.

The change in the macirq IRQ type also solved another long standing
issue affecting this SoC/PHY where EEE was causing the network
connection to die after stressing it with iperf3 (even though much
sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
well.

Fixes: feb3cbea0946 ("ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage")
Fixes: 6d28d577510f ("ARM64: dts: meson-axg: fix ethernet stability issue")
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Tested-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
arch/arm64/boot/dts/amlogic/meson-axg.dtsi
arch/arm64/boot/dts/amlogic/meson-gx.dtsi
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi