]> asedeno.scripts.mit.edu Git - linux.git/commit
vfio-mdev/samples: Use u8 instead of char for handle functions
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 19 Oct 2018 18:04:27 +0000 (11:04 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 17 Dec 2018 18:07:13 +0000 (11:07 -0700)
commit8ba35b3a0046d6573c98f00461d9bd1b86250d35
treeafdbc9949ff918a98ce36ee2bbf0e2822ceb5d02
parent9422f5871d5d9ad9e168e1329a43cf9169b04712
vfio-mdev/samples: Use u8 instead of char for handle functions

Clang warns:

samples/vfio-mdev/mtty.c:592:39: warning: implicit conversion from 'int'
to 'char' changes value from 162 to -94 [-Wconstant-conversion]
                *buf = UART_MSR_DSR | UART_MSR_DDSR | UART_MSR_DCD;
                     ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
1 warning generated.

Turns out that all uses of buf in this function ultimately end up stored
or cast to an unsigned type. Just use u8, which has the same number of
bits but can store this larger number so Clang no longer warns.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
samples/vfio-mdev/mtty.c