]> asedeno.scripts.mit.edu Git - linux.git/commit
Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message
authorDan Elkouby <streetwalkermc@gmail.com>
Fri, 6 Sep 2019 11:06:44 +0000 (14:06 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 6 Sep 2019 13:55:40 +0000 (15:55 +0200)
commit8bb3537095f107ed55ad51f6241165b397aaafac
tree4d1ed7c09cb08e75f92b4efc2f83e6c75bf15acb
parentd7ef0d1e39685b38c97b30daa6de0d50df004839
Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

hidp_send_message was changed to return non-zero values on success,
which some other bits did not expect. This caused spurious errors to be
propagated through the stack, breaking some drivers, such as hid-sony
for the Dualshock 4 in Bluetooth mode.

As pointed out by Dan Carpenter, hid-microsoft directly relied on that
assumption as well.

Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes")
Signed-off-by: Dan Elkouby <streetwalkermc@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/hid/hid-microsoft.c
net/bluetooth/hidp/core.c