]> asedeno.scripts.mit.edu Git - linux.git/commit
staging: wilc1000: Remove unnecessary pointer check
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Sep 2018 21:26:49 +0000 (14:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Sep 2018 18:53:53 +0000 (20:53 +0200)
commit8bdfc47f4ef186d73b2849fcdc065c78e20bd71a
treee15f4e69bc0369050626bd3652f357aa8e16fdf6
parent8de447ea9d0196d5ce54d96ab19e2a9c5d763ad8
staging: wilc1000: Remove unnecessary pointer check

Clang warns that the address of a pointer will always evaluated as true
in a boolean context:

drivers/staging/wilc1000/linux_wlan.c:267:20: warning: address of
'vif->ndev->dev' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (!(&vif->ndev->dev))
            ~  ~~~~~~~~~~~^~~
1 warning generated.

Since this statement always evaluates to false due to the logical not,
remove it.

Link: https://github.com/ClangBuiltLinux/linux/issues/121
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/linux_wlan.c