]> asedeno.scripts.mit.edu Git - linux.git/commit
regulator: wm831x ldo: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:54:01 +0000 (15:54 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:13:16 +0000 (15:13 +0000)
commit8be64b6d87bd47d81753b60ddafe70102ebfd76b
treef919aaf8d41a3535528872359dce95a00352cb5e
parentf7a621728a6a23bfd2c6ac4d3e42e1303aefde0f
regulator: wm831x ldo: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: d1c6b4fe668b ("regulator: Add WM831x LDO support")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/wm831x-ldo.c