]> asedeno.scripts.mit.edu Git - linux.git/commit
selftests: bpf: Ignore FIN packets for reuseport tests
authorLorenz Bauer <lmb@cloudflare.com>
Fri, 24 Jan 2020 11:27:52 +0000 (11:27 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 24 Jan 2020 21:12:13 +0000 (22:12 +0100)
commit8bec4f665e0baecb5f1b683379fc10b3745eb612
tree57325f0764a0775c16adcce31fc4a375842a2a8d
parentc31dbb1e41d1857b403f9bf58c87f5898519a0bc
selftests: bpf: Ignore FIN packets for reuseport tests

The reuseport tests currently suffer from a race condition: FIN
packets count towards DROP_ERR_SKB_DATA, since they don't contain
a valid struct cmd. Tests will spuriously fail depending on whether
check_results is called before or after the FIN is processed.

Exit the BPF program early if FIN is set.

Fixes: 91134d849a0e ("bpf: Test BPF_PROG_TYPE_SK_REUSEPORT")
Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200124112754.19664-3-lmb@cloudflare.com
tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c