]> asedeno.scripts.mit.edu Git - linux.git/commit
KVM: arm64: Define our own swab32() to avoid a uapi static inline
authorJames Morse <james.morse@arm.com>
Thu, 20 Feb 2020 16:58:38 +0000 (16:58 +0000)
committerMarc Zyngier <maz@kernel.org>
Sat, 22 Feb 2020 11:01:47 +0000 (11:01 +0000)
commit8c2d146ee7a2e0782eea4dd70fddc1c837140136
tree2a61fec4e43a9ebc5d677e0f2c227c898655d76d
parent5c37f1ae1c335800d16b207cb578009c695dcd39
KVM: arm64: Define our own swab32() to avoid a uapi static inline

KVM uses swab32() when mediating GIC MMIO accesses if the GICV is badly
aligned, and the host and guest differ in endianness.

arm64 doesn't provide a __arch_swab32(), so __fswab32() is always backed
by the macro implementation that the compiler reduces to a single
instruction. But the static-inline causes problems for KVM if the compiler
chooses not to inline this function, it may not be located in the
__hyp_text where __vgic_v2_perform_cpuif_access() needs it.

Create our own __kvm_swab32() macro that calls ___constant_swab32()
directly. This way we know it will always be inlined.

Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200220165839.256881-3-james.morse@arm.com
arch/arm64/include/asm/kvm_hyp.h
arch/arm64/kvm/hyp/vgic-v2-cpuif-proxy.c