]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/vmwgfx: Fix depth input into drm_mode_legacy_fb_format
authorSinclair Yeh <syeh@vmware.com>
Wed, 18 Jan 2017 22:14:01 +0000 (14:14 -0800)
committerSinclair Yeh <syeh@vmware.com>
Fri, 27 Jan 2017 04:52:54 +0000 (20:52 -0800)
commit8c95742e566f3945f992472a5f99f78aaa7f890b
tree0d6ff72ad124b7f71b07f8b498c6ca1e54342704
parent0f580386b6ad295c04c1b32120826494f8a29c1c
drm/vmwgfx: Fix depth input into drm_mode_legacy_fb_format

Currently the pitch is passed in as depth.  This causes
drm_mode_legacy_fb_format() to return the wrong pixel format.

The wrong pixel format will be rejected by vmw_kms_new_framebuffer(),
thus leaving par->set_fb to NULL.

This eventually causes a crash in vmw_fb_setcolreg() when the code
tries to dereference par->set_fb.

Signed-off-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c