]> asedeno.scripts.mit.edu Git - linux.git/commit
tty: serial: jsm: Remove unnecessary NULL checks
authorGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Fri, 22 Dec 2017 16:31:38 +0000 (14:31 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Jan 2018 15:37:03 +0000 (16:37 +0100)
commit8ca31ba8bb3441dd9928d2f92ffeee11dd2b6e63
tree41cdaf226f3935728e4c4d95846a317d2702f39a
parent69c444ba93b76f2da4f23449c72e83521142b243
tty: serial: jsm: Remove unnecessary NULL checks

After inspection made by Markus using Coccinelle software, he
observed that we could possibly be triggering a NULL pointer
dereference in 2 functions [0].

After discussion in mailing list, it was observed in fact
we have two unnecessary checks for NULL pointer, and they
were leading to Coccinelle warn. So, instead of reworking
the code as proposed by him, we hereby remove the
unnecessary checks, and also some unneeded extra lines in
the code.

These two unnecessary NULL checks were tracked in the call
chain as never NULL, so they can be safely removed.
No functional changes are intended.

[0] https://lkml.org/lkml/2017/11/29/705

Suggested-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/jsm/jsm_neo.c
drivers/tty/serial/jsm/jsm_tty.c