]> asedeno.scripts.mit.edu Git - linux.git/commit
scsi: lpfc: Fix failure to clear non-zero eq_delay after io rate reduction
authorJames Smart <jsmart2021@gmail.com>
Wed, 14 Aug 2019 23:56:35 +0000 (16:56 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 20 Aug 2019 02:41:08 +0000 (22:41 -0400)
commit8d34a59caecda9a7ce0cad108ee64c37aa0c9812
treec673fbeef1e59154ef32c16b63b7b81286a9f5d8
parent3cee98db2610fb633fcbdd0f85385f60dabbaf75
scsi: lpfc: Fix failure to clear non-zero eq_delay after io rate reduction

Unusually high IO latency can be observed with little IO in progress. The
latency may remain high regardless of amount of IO and can only be cleared
by forcing lpfc_fcp_imax values to non-zero and then back to zero.

The driver's eq_delay mechanism that scales the interrupt coalescing based
on io completion load failed to reduce or turn off coalescing when load
decreased. Specifically, if no io completed on a cpu within an eq_delay
polling window, the eq delay processing was skipped and no change was made
to the coalescing values. This left the coalescing values set when they
were no longer applicable.

Fix by always clearing the percpu counters for each time period and always
run the eq_delay calculations if an eq has a non-zero coalescing value.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_init.c