]> asedeno.scripts.mit.edu Git - linux.git/commit
um: Remove locking in deactivate_all_fds()
authorJohannes Berg <johannes.berg@intel.com>
Fri, 24 May 2019 19:37:00 +0000 (21:37 +0200)
committerRichard Weinberger <richard@nod.at>
Tue, 2 Jul 2019 21:27:05 +0000 (23:27 +0200)
commit8eacd6fca4044f470fc2eb0552ce6b8eab977e6c
tree2cd02a0b1c23e329c6e0e9aec857473335d21ee8
parent56fc187065451ebca74edb30d50de5f10a88339b
um: Remove locking in deactivate_all_fds()

Not only does the locking contradict the comment, and as
the comment says is pointless and actually harmful (all
the actual OS threads have exited already), but it also
causes crashes when lockdep is enabled, because calling
into the spinlock calls into lockdep, which then tries
to determine the current task, which no longer exists.

Remove the locking to let UML shut down cleanly in case
lockdep is enabled.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/kernel/irq.c