]> asedeno.scripts.mit.edu Git - linux.git/commit
netfilter: nf_ct_ext: invoke destroy even when ext is not attached
authorLiping Zhang <zlpnobody@gmail.com>
Sat, 29 Apr 2017 13:59:49 +0000 (21:59 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 1 May 2017 09:48:49 +0000 (11:48 +0200)
commit8eeef2350453aa012d846457eb6ecd012a35d99b
tree75d509dec2c42b8ae71f8e511309802d6fc1053f
parentd1908ca8dcb1a045cf0626be4513a28933f46d5e
netfilter: nf_ct_ext: invoke destroy even when ext is not attached

For NF_NAT_MANIP_SRC, we will insert the ct to the nat_bysource_table,
then remove it from the nat_bysource_table via nat_extend->destroy.

But now, the nat extension is attached on demand, so if the nat extension
is not attached, we will not be notified when the ct is destroyed, i.e.
we may fail to remove ct from the nat_bysource_table.

So just keep it simple, even if the extension is not attached, we will
still invoke the related ext->destroy. And this will also preserve the
flexibility for the future extension.

Fixes: 9a08ecfe74d7 ("netfilter: don't attach a nat extension by default")
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/nf_conntrack_extend.h
net/netfilter/nf_conntrack_extend.c