]> asedeno.scripts.mit.edu Git - linux.git/commit
net/mlx5e: Don't attempt to dereference the ppriv struct if not being eswitch manager
authorOr Gerlitz <ogerlitz@mellanox.com>
Mon, 4 Jun 2018 16:46:53 +0000 (19:46 +0300)
committerSaeed Mahameed <saeedm@mellanox.com>
Tue, 26 Jun 2018 22:26:28 +0000 (15:26 -0700)
commit8ffd569aaa818f2624ca821d9a246342fa8b8c50
tree52ee0b4ae3905008b928fa24c52fe72f7cb95606
parentce397d215ccd07b8ae3f71db689aedb85d56ab40
net/mlx5e: Don't attempt to dereference the ppriv struct if not being eswitch manager

The check for cpu hit statistics was not returning immediate false for
any non vport rep netdev and hence we crashed (say on mlx5 probed VFs) if
user-space tool was calling into any possible netdev in the system.

Fix that by doing a proper check before dereferencing.

Fixes: 1d447a39142e ('net/mlx5e: Extendable vport representor netdev private data')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reported-by: Eli Cohen <eli@melloanox.com>
Reviewed-by: Eli Cohen <eli@melloanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c