]> asedeno.scripts.mit.edu Git - linux.git/commit
hwmon: (pmbus/ibm-cffps) Fix LED blink behavior
authorEddie James <eajames@linux.ibm.com>
Wed, 6 Nov 2019 20:01:06 +0000 (14:01 -0600)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 6 Nov 2019 22:36:37 +0000 (14:36 -0800)
commit92b39ad440968bab38eb6577d63c12994601ed94
tree50550ecb2529d92a24ab2b79e5905594195c83e9
parent9861ff954c7e83e2f738ce16fbe15f8a1e121771
hwmon: (pmbus/ibm-cffps) Fix LED blink behavior

The LED blink_set function incorrectly did not tell the PSU LED to blink
if brightness was LED_OFF. Fix this, and also correct the LED_OFF
command data, which should give control of the LED back to the PSU
firmware. Also prevent I2C failures from getting the driver LED state
out of sync and add some dev_dbg statements.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20191106200106.29519-3-eajames@linux.ibm.com
Fixes: ef9e1cdf419a3 ("hwmon: (pmbus/cffps) Add led class device for power supply fault led")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/ibm-cffps.c