]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/vmwgfx: Fix 32-bit VMW_PORT_HB_[IN|OUT] macros
authorThomas Hellstrom <thellstrom@vmware.com>
Wed, 23 May 2018 14:11:24 +0000 (16:11 +0200)
committerThomas Hellstrom <thellstrom@vmware.com>
Wed, 23 May 2018 14:11:24 +0000 (16:11 +0200)
commit938ae7259c908ad031da35d551da297640bb640c
tree8cc17941da3d8775a7c84281eb1268eb34a12654
parent91ba9f28a3de97761c2b5fd5df5d88421268e507
drm/vmwgfx: Fix 32-bit VMW_PORT_HB_[IN|OUT] macros

Depending on whether the kernel is compiled with frame-pointer or not,
the temporary memory location used for the bp parameter in these macros
is referenced relative to the stack pointer or the frame pointer.
Hence we can never reference that parameter when we've modified either
the stack pointer or the frame pointer, because then the compiler would
generate an incorrect stack reference.

Fix this by pushing the temporary memory parameter on a known location on
the stack before modifying the stack- and frame pointers.

Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_msg.h