]> asedeno.scripts.mit.edu Git - linux.git/commit
crypto: user - fix potential warnings in cryptouser.h
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 23 Jul 2019 11:43:44 +0000 (20:43 +0900)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 2 Aug 2019 04:44:31 +0000 (14:44 +1000)
commit939f146b89c22c387d51f69b27ef031664f64cbe
treefe8a23c49aed66d3ae53e87693ffffd0a955fc38
parent68289c634344431d6f97480eb5384516f37e39b8
crypto: user - fix potential warnings in cryptouser.h

Function definitions in headers are usually marked as 'static inline'.

Since 'inline' is missing for crypto_reportstat(), if it were not
referenced from a .c file that includes this header, it would produce
a warning.

Also, 'struct crypto_user_alg' is not declared in this header.

I included <linux/crytouser.h> instead of adding the forward declaration
as suggested [1].

Detected by compile-testing this header as a standalone unit:

./include/crypto/internal/cryptouser.h:6:44: warning: ‘struct crypto_user_alg’ declared inside parameter list will not be visible outside of this definition or declaration
 struct crypto_alg *crypto_alg_match(struct crypto_user_alg *p, int exact);
                                            ^~~~~~~~~~~~~~~
./include/crypto/internal/cryptouser.h:11:12: warning: ‘crypto_reportstat’ defined but not used [-Wunused-function]
 static int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, struct nlattr **attrs)
            ^~~~~~~~~~~~~~~~~

[1] https://lkml.org/lkml/2019/6/13/1121

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
include/crypto/internal/cryptouser.h