]> asedeno.scripts.mit.edu Git - linux.git/commit
serial: sh-sci: Fix setting SCSCR_TIE while transferring data
authorHoan Nguyen An <na-hoan@jinso.co.jp>
Mon, 18 Mar 2019 09:26:32 +0000 (18:26 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Mar 2019 14:37:44 +0000 (15:37 +0100)
commit93bcefd4c6bad4c69dbc4edcd3fbf774b24d930d
tree6bebe1387dc16521f4e42a36657808fd6012e155
parent72ff51d8dd262d1fef25baedc2ac35116435be47
serial: sh-sci: Fix setting SCSCR_TIE while transferring data

We disable transmission interrupt (clear SCSCR_TIE) after all data has been transmitted
(if uart_circ_empty(xmit)). While transmitting, if the data is still in the tty buffer,
re-enable the SCSCR_TIE bit, which was done at sci_start_tx().
This is unnecessary processing, wasting CPU operation if the data transmission length is large.
And further, transmit end, FIFO empty bits disabling have also been performed in the step above.

Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c