]> asedeno.scripts.mit.edu Git - linux.git/commit
PCI/ASPM: Account for downstream device's Port Common_Mode_Restore_Time
authorBjorn Helgaas <bhelgaas@google.com>
Mon, 13 Nov 2017 14:50:30 +0000 (08:50 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 13 Nov 2017 21:05:24 +0000 (15:05 -0600)
commit94ac327e043ee40d7fc57b54541da50507ef4e99
tree257ae3867b9bad6345df120367735ae056badf45
parentee8bdfb6568d86bb93f55f8d99c4c643e77304ee
PCI/ASPM: Account for downstream device's Port Common_Mode_Restore_Time

Every Port that supports the L1.2 substate advertises its Port
Common_Mode_Restore_Time, i.e., the time the Port requires to re-establish
common mode when exiting L1.2 (see PCIe r3.1, sec 7.33.2).

Per sec 5.5.3.3.1, when exiting L1.2, the Downstream Port (the device at
the upstream end of the link) must send TS1 training sequences for at least
T(COMMONMODE) after it detects electrical idle exit on the Link.  We want
this to be long enough for both ends of the Link, so we should set it to
the maximum of the Port Common_Mode_Restore_Time for the upstream and
downstream components on the Link.

Previously we only looked at the Port Common_Mode_Restore_Time of the
upstream device, so if the downstream device required more time, we didn't
program the upstream device's T(COMMONMODE) correctly.

Fixes: f1f0366dd6be ("PCI/ASPM: Calculate and save the L1.2 timing parameters")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
Acked-by: Rajat Jain <rajatja@google.com>
CC: stable@vger.kernel.org # v4.11+
drivers/pci/pcie/aspm.c