]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amdgpu: Bail earlier when amdgpu.cik_/si_support is not set to 1
authorHans de Goede <hdegoede@redhat.com>
Thu, 10 Oct 2019 16:28:17 +0000 (18:28 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 12 Oct 2019 02:31:14 +0000 (21:31 -0500)
commit984d7a929ad68b7be9990fc9c5cfa5d5c9fc7942
tree78ed764c336ffa46acd4bc20448c7ccba6176bcd
parent8d13c187c42e110625d60094668a8f778c092879
drm/amdgpu: Bail earlier when amdgpu.cik_/si_support is not set to 1

Bail from the pci_driver probe function instead of from the drm_driver
load function.

This avoid /dev/dri/card0 temporarily getting registered and then
unregistered again, sending unwanted add / remove udev events to
userspace.

Specifically this avoids triggering the (userspace) bug fixed by this
plymouth merge-request:
https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/59

Note that despite that being a userspace bug, not sending unnecessary
udev events is a good idea in general.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1490490
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c