]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias
authorJakub Bartmiński <jakub.bartminski@intel.com>
Fri, 27 Jul 2018 14:11:43 +0000 (16:11 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 27 Jul 2018 15:03:39 +0000 (16:03 +0100)
commit9936ef55f254bb95fca9258539819a92d824497d
treea0e8b1b50f6b24c1a202b6cb44c08a652f312a08
parentc00db496bbd4586448bd46e19d79f424fd6faf6a
drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias

It would appear that the calculated GuC pin bias was larger than it should
be, as the GuC address space does NOT contain the "HW contexts RSVD" part
of the WOPCM. Thus, the GuC pin bias is simply the GuC WOPCM size.

v5:
Clarify the diagram to better represent the GuC address space.
Since we now don't use guc.base for the pin bias there's no need to
validate it. It also has already been verified in WOPCM init.

Bspec: 1180

Signed-off-by: Jakub Bartmiński <jakub.bartminski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180727141148.30874-1-jakub.bartminski@intel.com
drivers/gpu/drm/i915/intel_guc.c