]> asedeno.scripts.mit.edu Git - linux.git/commit
staging: ks7010_sdio: fix NULL pointer dereference and memory leak
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 12 Apr 2018 16:23:51 +0000 (11:23 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 12:24:47 +0000 (14:24 +0200)
commit9962d86dda3b99d2c7b4b87c921dd1c607a636e0
treec938b2e0c1eb2f30226034124627c72cedd88c50
parent95751f19b6942680f2884b44a127490c91aa4291
staging: ks7010_sdio: fix NULL pointer dereference and memory leak

priv is being explicitly dereferenced when it is still null, when
jumping to goto label err_free_netdev, before it is properly
updated with a valid memory address.

Also, when this happens, memory allocated for netdev at line 854:
netdev = alloc_etherdev(sizeof(*priv)) is not being free'd before
return, hence there is a memory leak.

The current code looks a bit too complicated and can be replaced
by just directly freeing netdev before return.

Notice that card->priv = NULL isn't required because the next thing
we do to card is kfree(card).

Addresses-Coverity-ID: 1467844 ("Explicit null dereferenced")
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks7010_sdio.c